On Mon, 12 Sep 2022 09:41:09 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to fix >> https://bugs.openjdk.org/browse/JDK-8170305? >> >> The commit in this PR changes the internal implementation of >> `HttpURLConnection` to ignore interim informational 1xx responses from >> server and continue to wait for the final response. This is a similar fix to >> what we did in the new `HttpClient` API in >> https://github.com/openjdk/jdk/pull/10169. >> >> A new test has been added to use the `HttpURLConnection` to reproduce the >> issue and verify the fix. >> >> tier1, tier2 and tier3 testing is in progress with this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > fix test server to avoid hang in test test/jdk/java/net/HttpURLConnection/Response1xxTest.java line 225: > 223: final HttpURLConnection urlConnection = (HttpURLConnection) > requestURI.toURL().openConnection(); > 224: // we expect the request to fail because the server unexpectedly > sends a 101 response > 225: Assert.assertThrows(IOException.class, () -> > urlConnection.getResponseCode()); Should we explicitly wait for ProtocolException here, since it's what we're throwing? ------------- PR: https://git.openjdk.org/jdk/pull/10229
