I'd suggest moving the implementation to ScriptRuntime and have a simple forwarder method in ScriptUtils.

That way ScriptFunction's makeFunction need not be public and so on. We have done similar impl. for parser API. Only reason to put the method into ScriptUtils is to access it from scripts. Actual impl. can be anywhere.

Other than that, +1

-Sundar

On Monday 14 October 2013 10:09 PM, Hannes Wallnoefer wrote:
Please review JDK-8026367: Add a sync keyword to mozilla_compat:

http://cr.openjdk.java.net/~hannesw/8026367/

Thanks,
Hannes

Reply via email to