The meat of this patch is the third and fourth patches below. Please read the third patch commit message for the details of what this is about.
The first and second patch fix a couple potential issues I noticed while I was doing the conversion, so I broke them out into separate commits. The last two patches also deal with a couple small issues I also noticed during the conversion. This is a large, but somewhat boring patch. I'll be testing and reviewing it more the rest of this week, but, as always, I appreciate feedback. Kevin J. McCarthy (6): Explicitly protect buffer memcpy() for a NULL parameter. Fix imap_delete_mailbox() double free and pass by value. Convert ACCOUNT fields to dynamically sized strings. Add NONULL checks around dynamic ACCOUNT string fields. Add a couple NULL parameter checks to url.c Convert mutt_account_tourl() account parameter to type const. account.c | 84 ++++++++++++++++++++++++++++++++++------------- account.h | 12 ++++--- browser.c | 7 ++-- buffer.c | 3 +- imap/auth_gss.c | 4 +-- imap/auth_login.c | 6 ++-- imap/browse.c | 30 ++++++++--------- imap/command.c | 13 ++++---- imap/imap.c | 61 +++++++++++++++++----------------- imap/imap.h | 3 +- imap/message.c | 10 +++--- imap/util.c | 42 +++++++++++++++--------- mutt_sasl_gnu.c | 8 ++--- mutt_socket.c | 24 +++++++------- mutt_ssl.c | 6 ++-- mutt_tunnel.c | 6 ++-- pop_auth.c | 14 ++++---- pop_lib.c | 2 +- url.c | 6 ++++ 19 files changed, 202 insertions(+), 139 deletions(-) -- 2.55.0
