On Sun, May 31, 2026 at 10:20:46AM +0200, Oswald Buddenhagen via Mutt-dev wrote:
> On Sun, May 31, 2026 at 07:57:43AM +0200, Rene Kita wrote:
> > Makes it easier to test locally and keeps the manifests dry.
> >
> the commit message should emphasize the fact that you are centralizing the
> configure command line args.
Will do.
> > +++ b/build
> > +tcc()
> > +{
> > + CC=tcc ./configure
> >
> no tab here?
Oops, left-over from the yml, good spot.
> > +# If no arguments were passed, get all the above function names (except
> > _die)
> > +# and drop the parentheses.
> >
> this is kind of redundant with the description at the top, esp. the naming
> of the function.
Yep, I commented that rather cryptic sed call first and then added the
general description above. I can remove comment here, if people prefer.
> > +for conf
> > +do
> > + cflags="$dft_flags"
> > + make distclean || :
>
> > + autoreconf -fi || _die "$?" "$conf" autoreconf
> >
> it makes no sense to have this in the loop. distclean does not (or at least
> should not) remove auto* artifacts.
> it would be different if you used `git clean -xfd` as the cleaning command,
> but that would be an awesome footgun.
Right, will move it outside the loop.
Thanks!
