Seeing the Full screen video as Full screen is addicting. What would that logic entail? ________________________________ From: Jonathan Almeida <jalme...@mozilla.com> Sent: Saturday, May 23, 2020 12:30 AM To: Bob Achgill <bobachg...@hotmail.com> Cc: mobile-firefox-dev@mozilla.org <mobile-firefox-dev@mozilla.org> Subject: Re: Html fixed menu half covered after Fullscreen video
Ah right, I see it now. In that case, it depends what you want the outcome to be: If you want your custom title bar (the one that says 'Reference Browser') to hide/show when fullscreen is enabled/disabled, you would need to add that logic into the fullScreenChanged method. If you want your custom title bar to always be there, then a simple solution to try is to remove the enterToImmersiveMode and exitImmersiveModeIfNeeded calls in the same fullScreenChanged method. That would stop the browser from expanding over the status and system navigation bars. Cheers, -Jonathan A On Tue, May 19, 2020 at 10:44 PM Bob Achgill <bobachg...@hotmail.com<mailto:bobachg...@hotmail.com>> wrote: You mean the bar at the bottom? I'm sorry it had self hidden when I did that screenshot. Same prognoses? ________________________________ From: Jonathan Almeida <jalme...@mozilla.com<mailto:jalme...@mozilla.com>> Sent: Tuesday, May 19, 2020 6:26 PM To: Bob Achgill <bobachg...@hotmail.com<mailto:bobachg...@hotmail.com>> Cc: mobile-firefox-dev@mozilla.org<mailto:mobile-firefox-dev@mozilla.org> <mobile-firefox-dev@mozilla.org<mailto:mobile-firefox-dev@mozilla.org>> Subject: Re: Html fixed menu half covered after Fullscreen video The urlbar is sometimes referred to as the toolbar, sorry for the confusion. From the screenshot, I don't see one there, so I'd try notifying the engine that there is no dynamic urlbar by setting the value to 0 (see previous message). Cheers, -Jonathan A On Tue, May 19, 2020 at 5:20 PM Bob Achgill <bobachg...@hotmail.com<mailto:bobachg...@hotmail.com>> wrote: I think I am using the toolbar if the toolbar is the one that has the Title Reference Browser. Does that change your suggestion? ________________________________ From: Jonathan Almeida <jalme...@mozilla.com<mailto:jalme...@mozilla.com>> Sent: Tuesday, May 19, 2020 2:17 PM To: Bob Achgill <bobachg...@hotmail.com<mailto:bobachg...@hotmail.com>> Cc: mobile-firefox-dev@mozilla.org<mailto:mobile-firefox-dev@mozilla.org> <mobile-firefox-dev@mozilla.org<mailto:mobile-firefox-dev@mozilla.org>> Subject: Re: Html fixed menu half covered after Fullscreen video Hey Bob, We fixed this in Reference Browser by notifying the EngineView when the height of the toolbar changed. From the screenshots, it looks like you aren't using the toolbar, so you might have to alter that change to always call `setDynamicToolbarMaxHeight` with 0. Cheers, -Jonathan A On Tue, May 19, 2020 at 4:28 AM Bob Achgill <bobachg...@hotmail.com<mailto:bobachg...@hotmail.com>> wrote: Hey guys, Is this a bug? I have an html fixed menu that is at the top of my html context and is fixed to stay in position as the html page is scrolled. On return from Fullscreen video the fixed menu is half covered and remains that way till I go to a non geckoview screen in my app and return to the geckoview screen. Just changing html pages and return to the page with the fixed menu does not reset the correct fixed position. See attached screen shot. Thanks! Bob Achgill _______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org<mailto:mobile-firefox-dev@mozilla.org> https://mail.mozilla.org/listinfo/mobile-firefox-dev<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.mozilla.org%2Flistinfo%2Fmobile-firefox-dev&data=02%7C01%7C%7C9997189d93fe4216627d08d7feda5de5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637258086133047839&sdata=XJc%2Bp%2B6wH55Gy3CaiRuCpzF6X0BaXwICundmfNMi0z0%3D&reserved=0>
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
