The patches causing this failure have now been backed out on
mozilla-central, and should hopefully be in a nightly soon.
* How this happened *
- In Bug 1264489 I tried to ensure we're not accessing the database on
the UI thread
- We were accessing the DB when inflating the main app menu
-- This happens whenever you use the menu on a phone
-- This happens during startup on tablets
- To avoid this, I moved the code which causes DB to a runnable posted
to the background thread
- This code accessed the UI, which causes an exception to be thrown
- The background thread silently dies (Sebastian is investigating this
in bug 1279488)
- Everything else that wants to be run on the background thread won't run:
including favicons, push, search, etc.
(But only if you've used the menu, or are on a tablet)
- I attempted to fix this by posting the UI callback back to the UI thread
- Causing all robocop tests to fail
-> Immediate backout of this fix
- Decided to revert the original patches instead
* Why didn't tests catch it *
What I thought was an unrelated intermittent test failure, was actually
a test that used the menu, which later failed because background threads
were broken (saving a bookmark: opens menu, tries to press the star
button -> star button uses the background thread to save the bookmark).
* Fixing the original bug *
- Probably not that worthwhile, no one has complained so far
(However the menu is noticeably slower to appear the first time it is used)
- Complicated to fix, DB access happens deep in the innards of
GeckoActionProvider,
which is called during menu inflation.
ATB,
Andrzej
On 6/10/16 4:00 AM, Sebastian Kaspari wrote:
Hey everyone,
I just wanted to let you know that we are currently fixing a bug hat
broke running background threads in Nightly (bug 1279332
<https://bugzilla.mozilla.org/show_bug.cgi?id=1279332>). As a result
of this a lot of things are not working right now (Just look at some
of the linked bugs and duplicates).
I filed (and debugged) a couple of bugs today until I realized that
this is all related to bug 1279332. So before running into the same
trap - follow this bug. :)
Best,
Sebastian
_______________________________________________
mobile-firefox-dev mailing list
mobile-firefox-dev@mozilla.org
https://mail.mozilla.org/listinfo/mobile-firefox-dev
_______________________________________________
mobile-firefox-dev mailing list
mobile-firefox-dev@mozilla.org
https://mail.mozilla.org/listinfo/mobile-firefox-dev
