Emily, and others
Background:
We are trying to maintain some separation between MenuView code and the
rest of the app, with the intention that a) this is good for the code b)
MenuView could end up being a good candidate to be an open-source
sub-project unrelated to the main app.
MenuConfiguration and AppState control what gets displayed as in a given
menu.
AppMenuConfiguration is how the menu and tool bar should be configured
based on an immutable AppState.
At the moment, AppState is very browser specific and not easily cleavable
from the rest of the app.
This email is about using the existing prefs in the browser to influence
AppMenuConfiguration.
MenuConfiguration has two properties
var menuItems: [MenuItem] { get }
var menuToolbarItems: [MenuToolbarItem]? { get }
I'm wanting to display different menu items depending on the value of a
Pref.
In the feature I'm working on at the moment, this is display something
different if a pref isn't set, AND display in a different place if a
different pref is set. (i.e. two different things, and I'm sure this won't
be the last feature to want to do this).
We've hemmed and hawwed at the AppState, and eventually decided that we
probably shouldn't do anything too ambitious/complicated to start with, and
see how far we get before
So do we need an immutable copy of prefs to stick on the appstate?
I understand there is a flux-wards direction to our intended architecture,
but I'd like to discuss a) how soon, how far do we want to go, b) what we
want to compromise upon/what technical debt do we want to incur to ship
this feature.
– James
_______________________________________________
mobile-firefox-dev mailing list
mobile-firefox-dev@mozilla.org
https://mail.mozilla.org/listinfo/mobile-firefox-dev
