Hey all. *tldr; update the version-control-tools where your reviewboard extension is loaded from. This can be done with `./mach mecurial-setup` or by manually running `hg pull && hg update` from the repository.*
I landed my changes into the reviewboard extension to notify a user of checkstyle violations when pushing to reviewboard [1]. We decided not to block push [2] but rather just warn the user of the violations. If this doesn't work to keep violations out of reviews (if that's the case, let me know!), we can add a prompt. In order to take advantage of these changes, you need to upgrade your version-control-tools repository where your reviewboard extension is loaded from. We should also encourage all new contributors to use reviewboard in order to take advantage of this functionality. If you don't want to wait until you push to reviewboard to be alerted of violations, you can also set up the checkstyle-idea extension [3]. Happy coding! - Mike (:mcomella) [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1263201 [2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1263201#c18 [3]: https://wiki.mozilla.org/Mobile/Fennec/Android/Static_analysis/checkstyle-idea
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
