> > Any objections if I change FRAMEWORK_SEARCH_PATHS from: > > $(inherited) > $(PROJECT_DIR)/Carthage/Build/iOS > $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME) > $(BUILD_DIR)/Debug$(EFFECTIVE_PLATFORM_NAME) > > To: > > $(inherited) > $(PROJECT_DIR)/Carthage/Build/iOS > $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME)
I think this should be fine. The release/debug additions were added because the non-Carthage projects that we build from their own Xcode projects (SQLite/FxA) have configurations named release/debug. The only thing I would be careful about is if we're still able to link to debug-enabled framework using this approach since I imagine the Release configuration doesn't include debug options enabled. Does this mean that these frameworks (which all happen to be embedded in > our app instead of Carthage frameworks) should be made aware of the > different configurations we have? (Fennec, Firefox, FirefoxBeta, etc.) I'm not sure. When I did the project file work to migrate everything to use our configurations, I was hesitant on changing these dependencies because they shouldn't need to be aware of our project's configurations to work. I think changing these projects to use our configuration names will make it difficult in the future to integrate other third party libraries because we'll need to modify them to work with our project. It would be ideal if all our dependencies followed the same Carthage abstraction where we just pull in the frameworks. I know that SQLite and libsqlcipher is now available as a combined packaged using Carthage: https://github.com/stephencelis/SQLiteCipher.swift. This would leave FxA the remaining locally-build dependency. On Thu, Apr 14, 2016 at 6:03 PM, Stefan Arentz <sare...@mozilla.com> wrote: > > ld: warning: directory not found for option > ‘-F/Users/sarentz/Library/Developer/Xcode/DerivedData/Client-hgonbrgqywqgohfpnlygovbykvqa/Build/Products/Debug-iphonesimulator > > Any objections if I change FRAMEWORK_SEARCH_PATHS from: > > $(inherited) > $(PROJECT_DIR)/Carthage/Build/iOS > $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME) > $(BUILD_DIR)/Debug$(EFFECTIVE_PLATFORM_NAME) > > To: > > $(inherited) > $(PROJECT_DIR)/Carthage/Build/iOS > $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME) > > I can still correctly do Fennec and Firefox(Beta) builds after this change. > > > I think there may be a bigger problem here, because most frameworks > correctly end up in: > > > ~/Library/Developer/Xcode/DerivedData/Client-hgonbrgqywqgohfpnlygovbykvqa/Build/Products/FirefoxBeta-iphoneos > > While some end up here: > > ls -l > ~/Library/Developer/Xcode/DerivedData/Client-hgonbrgqywqgohfpnlygovbykvqa/Build/Products/Release-iphoneos/ > total 9328 > drwxr-xr-x 7 sarentz staff 238 Apr 14 17:51 FxA.framework > drwxr-xr-x 3 sarentz staff 102 Apr 14 17:51 FxA.framework.dSYM > drwxr-xr-x 7 sarentz staff 238 Apr 14 17:53 SQLite.framework > drwxr-xr-x 3 sarentz staff 102 Apr 14 17:53 SQLite.framework.dSYM > -rw-r—r-- 1 sarentz staff 4774856 Apr 14 17:52 libsqlcipher.a > > > Does this mean that these frameworks (which all happen to be embedded in > our app instead of Carthage frameworks) should be made aware of the > different configurations we have? (Fennec, Firefox, FirefoxBeta, etc.) > > S. > > _______________________________________________ > mobile-firefox-dev mailing list > mobile-firefox-dev@mozilla.org > https://mail.mozilla.org/listinfo/mobile-firefox-dev >
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
