Sorry Mike! Just realized that I never replied to your email.

> Two questions:
>
> What is the motivation for this change?

It's part of a general trend to move things out of GeckoEvent and into
native calls (see bug 1188959). Using native calls is more efficient
than allocating and passing a GeckoEvent object, and the resulting
code (especially on the C++ side) is less error-prone and requires
less maintenance in general.

> Should we add @deprecated to GeckoAppShell.sendEventToGecko?

Not yet, because we still use GeckoEvent for a lot of other events
(but no longer for observer notification).

Thanks,
Jim

> - Mike
>
> On Thu, Mar 24, 2016 at 10:28 AM, Jim Chen <nc...@mozilla.com> wrote:
>>
>> Hi all,
>>
>> Just a heads-up that new code in 48 should use,
>>
>> > GeckoAppShell.notifyObservers("foo", "bar");
>>
>> instead of,
>>
>> > GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("foo",
>> > "bar"));
>>
>> All behavior remain the same as before. Be careful that upflits should
>> continue to use the old API.
>>
>> Thanks,
>> Jim
>> _______________________________________________
>> mobile-firefox-dev mailing list
>> mobile-firefox-dev@mozilla.org
>> https://mail.mozilla.org/listinfo/mobile-firefox-dev
>
>
_______________________________________________
mobile-firefox-dev mailing list
mobile-firefox-dev@mozilla.org
https://mail.mozilla.org/listinfo/mobile-firefox-dev

Reply via email to