Hey all. I landed my patch to have GeckoApp extend AppCompatActivity [1]. What does this mean for you?
- Look out and report any mysterious changes in the UI! - XML attributes for AppCompat APIs used in GeckoApp should forgo "android:", e.g. "windowActionBar" as opposed to "android:windowActionBar". A full list of AppCompat attrs can be found at [2] Why might there be mysterious changes to the UI? When we were using the AppCompat theme but not extending the AppCompat class, there were inconsistencies in how the AppCompat APIs worked – sometimes you'd need the `android:*` attribute, sometimes the non-prefixed attribute, and sometimes both! Now we shouldn't need these exceptions, but it's possible we originally wrote the code in a state that doesn't work correctly with the new, correct configuration. Keep an eye out! What's next for AppCompat? We should move towards extending all of our activities with AppCompatActivity (e.g. preferences [3]). After this, we'll be in a better place to continue unifying the UI [4]. Let me know if you have questions! - Mike (:mcomella) [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1220309#c25 [2]: http://androidxref.com/6.0.0_r1/xref/frameworks/support/v7/appcompat/res/values/attrs.xml [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1205124 [4]: https://bugzilla.mozilla.org/show_bug.cgi?id=1202076
_______________________________________________ mobile-firefox-dev mailing list mobile-firefox-dev@mozilla.org https://mail.mozilla.org/listinfo/mobile-firefox-dev
