On 6/06/2010, at 1:27 PM, Uwe Dippel wrote:

> Philip Guenther <guenther <at> gmail.com> writes:
>
>> You now have and now it
>> seems the core discussion is just about whether (or where) an
>> additional "rm -rf /usr/obj/*" should be added to help people that
>> know enough to set up the source tree for building/patching by
>> untaring src.tar.gz but don't know to remove the obj tree at the same
>> time.
>
> So, no diff here, but a suggestion:
>
> If one needs to avoid stale stuff lying around in /usr/obj at applying a
patch,
> the only logical consequence is, to clean out all /obj totally, even before
> applying a single patch.
> If I am correct, the instructions should be clear for 00N_ThisApp.patch:
>
> Apply by doing:
>         cd /usr/src
>         patch -p0<  00N_ThisApp.patch
>
> Clean the build directories by issuing the command /usr/sbin/mk_build_clean
>
> And then rebuild and install the library and statically-linked binaries
> that depend upon it:
>
>         cd lib/libThisApp
>         make obj
>         make depend
>         make includes
>         make
>         make install
>         cd ../../sbin
>         make obj
>         make depend
>         make
>         make install
>
>
> , where mk_build_clean is just the set of steps pointed out in 'man
release',
> respectively in FAQ5.
> To me, and I guess Richard Toohey, the case is solved.
>
> Everyone who can read, and likes following instructions, can read and
follow
> this easily.

No, the point that people are making (over and above HOW you report an
issue) is that blindly following the patch instructions is *not* good enough.

It doesn't matter how much more gets put in the docs or the patch files,
we didn't *think* enough about what we were doing - that's my mistake
and I intend to learn from it.

If we just end up blindly doing stuff and clicking on buttons to see what
happens, we should probably be using another operating system.

This *is* in the docs - if you read a little bit further than we did, and do a
bit
more thinking.

Maybe another line in the patch file would help ... but then what about the
next
issue that comes up?  The patch file doesn't tell you how to put the source
there,
so if you do *literally* follow "cd /usr/src" and then the patch line, you
won't even
have the right source, will you?  You had to read elsewhere to know how to
get
the source in the first place.

Or next someone will argue that "Then build and install a new kernel" is too
brief and there should be full instructions in every patch file.

If we go off and read the FAQ about building the kernel because the full
instructions
were not in the patch file, why didn't we go and read the FAQ about building
userland?

That's my take on it and I think the list members are rather bored of this
thread!
>
> Uwe

Reply via email to