On Sat, Dec 24, 2022 at 09:50:01AM +0100, Robert Nagy wrote:
> looks ok

Alright, thanks. I committed the diff.

Caspar

> 
> On 23/12/22 21:07 +0100, Caspar Schutijser wrote:
> > On Fri, Dec 23, 2022 at 06:58:28PM +0100, Robert Alessi wrote:
> > > On Fri, Dec 23, 2022 at 04:44:54PM +0100, Robert Alessi wrote:
> > > > On Fri, Dec 23, 2022 at 03:37:04PM +0100, Caspar Schutijser wrote:
> > > 
> > > [...]
> > > 
> > > > > I'm not a Big Blue Button user but visiting the URL below with
> > > > > Chromium and WebAssembly disabled does show some WebAssembly-related
> > > > > error messages on the developer console (press F12 to access that
> > > > > console). So probably it's related to WebAssembly after all.
> > > > 
> > > > Well spotted, thank you.  I had no idea that BBB might be using WASM.
> > > > Besides, I just tried with Iridium *and ENABLE_WASM=1* and here follows
> > > > what I get:
> > > > 
> > > > Uncaught ReferenceError: WebAssembly is not defined
> > > 
> > > [...]
> > > 
> > > So it's a fact: both Jitsi and BBB use WASM as can be seen from this:
> > > https://marc.info/?l=openbsd-ports&m=165435142107165&w=2  (Read the
> > > whole thread as it is most informative.)
> > > 
> > > Yet I can't figure out why `ENABLE_WASM=1 iridium` doesn't work with
> > > BBB.
> > > 
> > > Does anyone have a clue?
> > 
> > I compared www/chromium/files/chrome and www/iridium/files/iridium and
> > I noticed that the ENABLE_WASM stuff is missing from the latter.
> > 
> > Robert, is that on purpose? If not, here is a diff to fix that. OK?
> > 
> > Caspar
> > 
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/www/iridium/Makefile,v
> > retrieving revision 1.149
> > diff -u -p -r1.149 Makefile
> > --- Makefile        13 Dec 2022 12:50:03 -0000      1.149
> > +++ Makefile        23 Dec 2022 19:35:08 -0000
> > @@ -11,7 +11,7 @@ DPB_PROPERTIES+=  lonesome
> >  COMMENT=           Iridium browser
> >  
> >  V=                 2022.12.108.1
> > -REVISION=          0
> > +REVISION=          1
> >  
> >  DISTNAME=          iridium-browser-${V}
> >  PKGNAME=           iridium-${V}
> > Index: files/iridium
> > ===================================================================
> > RCS file: /cvs/ports/www/iridium/files/iridium,v
> > retrieving revision 1.7
> > diff -u -p -r1.7 iridium
> > --- files/iridium   11 Mar 2022 20:09:56 -0000      1.7
> > +++ files/iridium   23 Dec 2022 19:35:08 -0000
> > @@ -53,4 +53,7 @@ export LD_LIBRARY_PATH
> >  [ -f ~/.config/user-dirs.dirs ] || \
> >     echo 'XDG_DOWNLOAD_DIR="$HOME/Downloads"' > ~/.config/user-dirs.dirs
> >  
> > -LANG=${_l} exec "/usr/local/iridium/iridium" 
> > --disable-features=WebAssembly,AsmJsToWebAssembly,WebAssemblyStreaming 
> > --js-flags=--noexpose-wasm "${@}"
> > +[ -z ${ENABLE_WASM} ] && \
> > +   
> > _NOWASM="--disable-features=WebAssembly,AsmJsToWebAssembly,WebAssemblyStreaming
> >  --js-flags=--noexpose-wasm"
> > +
> > +LANG=${_l} exec "/usr/local/iridium/iridium" ${_NOWASM} "${@}"
> 
> -- 
> Regards,
> Robert Nagy

Reply via email to