Luke A. Call <[email protected]> wrote:
> On 2022-10-26 11:57:23-0000, Stuart Henderson <[email protected]>
> wrote:
> > On 2022-10-24, Peter Fraser <[email protected]> wrote:
> > > I make a stupid mistake; I didn't check partition sizes before doing a
> > > sysupgrade.
> > > sysupgrade ran out of space or /usr in the middle of the upgrade.
> > > I know I should have checked first but it would be nice if sysupgrade did
> > > warn me.
> > > The site was a 20-minute drive away, and their down time was a lot longer
> > > then I expected.
> >
> > It would be nice, but it's tough to reliably test this without actually
> > extracting the files (and a warning with many false triggers wouldn't be
> > all that much use either ..)
>
> Thanks for that info, it is interesting.
>
> I'm just me, but would definitely prefer a warning that
> suggests a potential problem and says what to
> check to be sure, over having to do a recovery. I do follow the
> instructions and check it (so far, barring mistakes), but I imagine that
> the program can still, without extracting the files, check it as well as
> I would (df -h...), but more reliably.
here you go, you can use this diff.
Index: sysupgrade.sh
===================================================================
RCS file: /cvs/src/usr.sbin/sysupgrade/sysupgrade.sh,v
retrieving revision 1.48
diff -u -p -u -r1.48 sysupgrade.sh
--- sysupgrade.sh 8 Jun 2022 09:03:11 -0000 1.48
+++ sysupgrade.sh 26 Oct 2022 17:02:35 -0000
@@ -92,6 +92,8 @@ done
(($(id -u) != 0)) && err "need root privileges"
+echo your /usr might be too small
+
if $RELEASE && $SNAP; then
usage
fi
