On 02/14/13 06:50, Stuart Henderson wrote: > On 2013/02/14 12:19, Jeremie Le Hen wrote: >> > > >> > One minor comment: you don't *need* to reboot. Although it's a good >> > practice to reboot after >> > you're done setting things up to make sure you don't have any ephemeral >> > configurations (that >> > you will obviously have forgotten about when you reboot for some other >> > reason and find you >> > something is not working as expected). >> >> I fully agree on your comment. >> >> > Provided this is explained in 6.2.5, perhaps the 'Reboot and voil?' line >> > should be removed ? > > We need to say something; we could either leave it as-is about rebooting, > or we could add the same information that is scattered through half the other > examples in the file. I think it's fine as-is, really. > >> > On the other hand, the section right before the one Jeremie wrote also >> > recommends a reboot, so >> > it is consistent in that way. >> >> ehis is one of the reason I put this line. Also, my reasoning was that >> people who are skilled enough to configure this manually (I mean, >> without a reboot) probably don't need to go through this document. > > I agree, (well, either they don't need to use the document, or they can > pick the relevant bits). No need to complicate it with "you can do it > this way, or do it that way, but if you do it that way then watch out for > this and this". >
agreed. I have no desire to reinforce many people's bad habit of making config changes, manually implementing them, and not rebooting to find out of the machine comes up as they hope. Many people consider it a badge of honor that they don't have to reboot their machine to make config changes, and most of their coworkers would like to slap 'em silly every time they have to reboot one of their machines when they aren't around...and half the services don't come up, the mount points are all wrong, and things are generally just bad. I'm good with this diff going in as-is, but a few comments regarding style... We don't need to be naming specific machines and manufacturers. "...we have a machine with four vr(4) interfaces ..." would work just fine. I see Stuart did this. While I personally love the "Reboot and voila", I'm always concerned about how non-English/French readers would handle this -- does a Chinese person reading the FAQ understand this? I'm hopelessly monolingual, so maybe I worry about the wrong things here (and this from the guy who "re-styled" the FAQ as the Hitchhiker's Guide / Bugbuster's Guide, so what do I know? :) but...good work, thanks! Nick.
