On 2011/06/03 17:42, Amit Kulkarni wrote: > On Fri, Jun 3, 2011 at 5:09 PM, Nigel Taylor > <[email protected]> wrote: > > Hi, > > > > Needs an RB_GENERATE, see devel/libgtop2/files/procmap.c used this at > > end of file. Adding this builds, but I get a Seg fault when attempting > > running built lsof on amd64. > > > > /* > > * Don't implement address comparison. > > */ > > static __inline int > > no_impl(void *p, void *q) > > { > > abort(); /* Should not be called. */ > > return 0; > > } > > > > > > RB_GENERATE(uvm_map_addr, vm_map_entry, daddrs.addr_entry, no_impl); > > > > > Good catch! I also get the segfault. > > I tweaked the configure, which is kinda silly but here's Stuart's > original patch + Nigel's diff + configure tweak all in one package. I > packaged it so it will extract to folder lsof. > Thanks
Any tweaks to configure will be a separate commit after the port is fixed, no need for the distraction for now. I'm not quite sure why you removed the XXX comment about the name cache either. btw inline diffs please, tars are only for new ports. > I noticed lsof installs in /usr/local/sbin, which is a no-no. apart from getting Tutti Frutti Summer Love stuck in my head again (thanks!) I don't see a problem here.
