On Wed, 25 Jun 2025, LIU Hao wrote:

在 2025-6-25 16:08, Martin Storsjö 写道:
Both for UCRT and for msvcrt.dll, we end up calling the CRT DLL
provided functions directly, so these issues are outside of our
own emulation wrappers.

Just waive the test for these configurations.

Signed-off-by: Martin Storsjö <mar...@martin.st>
---
  mingw-w64-crt/testcases/t_aligned_alloc.c | 30 ++++++++++++++++++-----
  1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/mingw-w64-crt/testcases/t_aligned_alloc.c b/mingw-w64-crt/testcases/t_aligned_alloc.c
index 1e4cbdea2..d80a3d318 100644
--- a/mingw-w64-crt/testcases/t_aligned_alloc.c
+++ b/mingw-w64-crt/testcases/t_aligned_alloc.c
@@ -25,6 +25,18 @@
    } \
  } while (0)
  +#ifndef BROKEN_REALLOC_SHRINK
+#if defined(__aarch64__)
+/* On aarch64, both UCRT and msvcrt.dll, a _aligned_realloc that attempts to

                ^ here should be a 'with'.
                                           ^ this reads like 'an'.

Other than that, the 1st and 3rd patches look good to me.

Thanks, I pushed these and the other testcase fixes now.

With that, these testcases should run fine again, across {msvcrt,ucrt,ucrtbase} x {i686,x86_64,armv7,aarch64} x {gcc,clang}. But we'd need to settle a way to fix up the makefile integration of them before we can add them to the CI in the master branch.

// Martin

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to