On Tuesday 24 June 2025 17:19:19 Martin Storsjö wrote:
> On Mon, 23 Jun 2025, Pali Rohár wrote:
> 
> > On Monday 23 June 2025 15:42:08 Martin Storsjö wrote:
> > > On Sat, 21 Jun 2025, Pali Rohár wrote:
> > > 
> > > > Setting the lib32_libscrnsavw_a_CFLAGS variable automatically turns off
> > > > usage of AM_CFLAGS variable for that target. As the AM_CFLAGS contains 
> > > > the
> > > > mingw-w64 CRT build flags, specify it manually in 
> > > > lib32_libscrnsavw_a_CFLAGS
> > > > variable. Do same for all architectures.
> > > > ---
> > > > mingw-w64-crt/Makefile.am | 8 ++++----
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > Can you clarify the "fix" part here? Yes we should't be accidentally
> > > omitting AM_CFLAGS - but is this a consistency fix, or is there a 
> > > noticeable
> > > breakage somewhere which gets fixed too?
> > > 
> > > (The patch itself looks ok.)
> > > 
> > > // Martin
> > 
> > Yea, I used generic word "fix". It is consistency fix for now. I did not
> > see issues yet.
> 
> Ok, then I pushed this patch with the subject rephrased to point out that
> we're just adding the missing AM_CFLAGS.
> 
> // Martin

Ok, thanks!


_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to