On Thursday 19 June 2025 20:52:59 Martin Storsjö wrote: > On Sun, 15 Jun 2025, Pali Rohár wrote: > > > Both msvcrt and UCRT ABI uses for off_t-based function without any suffix > > in their name the 32-bit long off_t type for both 32-bit and 64-bit > > architectures. > > The non-English word order makes this sentence very hard to parse. Right > now, this sentence reads "X uses for Z Y" - which isn't how such things are > said in English, and makes it very hard to spot which part of the long > sentence belongs to the "for Z" part and which part is the "Y" part. The > proper word order would be "X uses Y for X".
Feel free to change any wording. I'm fine if anybody else improve English in commit messages. > Other than that, I didn't really spot any issue with it by reading it > through. And a run through the CI looked fine. > > But given the fallout from the stat patches, I wonder if we should have some > sort of test that tries to call all the functions that are involved in this > patchset, that we could test build - ideally for all CRTs, but in practice > at least for msvcrt+ucrtbase+ucrt, to make sure we don't miss any. > > // Martin I will definitely prepare mingw-w64-crt/testcases/* for those _*stat* functions, which can catch these issue. I can also send a separate patch which will add test cases for calling all of these functions. The remaining part is to add and enable CI testing of these mingw-w64 integrated test suite, which can be run by the "make check" command. _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
