Hi, Can I ask for first 10 patches in this series to be reviewed?
They mostly introduce changes to the build system (e.g. fixing `make dist`) or remove unused things (e.g. configure checks and no longer used code). Only the last patch adds support for `_USE_32BIT_TIME_T` and `_TIME_BITS`, which probably doesn't make sense until stat-related patches which add recognition of `_TIME_BITS` pushed/reviewed. Small note about patch 9. I wonder if using `mbstowcs` instead of `mbsrtowcs` could be preferred since (AFAIK) all CRTs have `mbstowcs`, while `mbsrtowcs` is available only starting with mavcr80.dll and some OS-specific versions of msvcrt.dll (I believe it is emulated for CRTs which do not have it). - Kirill Makurin ________________________________ From: Kirill Makurin <maiddais...@outlook.com> Sent: Tuesday, April 22, 2025 5:20:02 PM To: mingw-w64-public <mingw-w64-public@lists.sourceforge.net> Subject: [Mingw-w64-public] [V2] winpthreads: add support for _USE_32BIT_TIME_T and _TIME_BITS macros This is the updated patch series. Some patches have been reordered and new patches have been added. Some patches have been updated. New patches are: 0002.txt-0005.txt and 0010.txt. 0002.txt: Get rid of now unused `WINPTHREAD_DBG` macro. All code guarded by this macro has been removed. In addition, private definition of `assert` and (unused) `fixme` macros in misc.h has also been removed. For affected source files, assert.h has been included. 0003.txt: Internal header file `winpthread_internal.h` has been removed. This file declared two functions: `__pth_gpointer_locked` and `pthread_delay_np_ms`. The `__pth_gpointer_locked` is also declared in thread.h, all its users already had thread.h included. Since `pthread_delay_np_ms` is defined in thread.c, its declaration has been moved to thread.h. An underscore has been prepended to the name of this function to explicitly mark it as internal. 0004.txt: Remove ref.c and ref.h. They are empty. 0005.txt: Move definition of `WIN32_LEAN_AND_MEAN` from Makefile.am to source files. I took freedom to group and reorder includes in source file and internal header files. 0010.txt: Silence `-Wprio-ctor-dtor` warning in misc.c which results from `__attribute__((constructor(0)))`. Changes: New macro `WINPTHREADS_TIME_BITS` was added to pthread_compat.h which will expand into either `32` or `64` depending on state of ` _USE_32BIT_TIME_T` and `_TIME_BITS` macros. `SIZEOF_TIME_T` is no longer used. Few macros named `WINPTHREAD_*_DECL` were added in pthread_compat.h. They are used to conditionally declare some functions either as external (with __declspec(dllexport) in case when building DLL) or static inline (for client code). Function definitions in header files now also used to provide external version when corresponding source file is compiled. - Kirill Makurin _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
