On Monday 17 March 2025 23:47:19 Pali Rohár wrote:
> On Monday 17 March 2025 23:44:25 Jacek Caban wrote:
> > On 17.03.2025 21:35, Pali Rohár wrote:
> > > Enable underscored fpreset alias for ARM targets in crt-aliases.def.in
> > > include file, which is automatically included into all msvcr*.def.in and
> > > ucrt*.def.in files.
> > >
> > > Underscored alias is still present in api-ms-win-crt-runtime-l1-1-0.def.in
> > > file as api-ms-win-crt*.def.in files do not use crt-aliases.def.in yet.
> > >
> > > This change fixes more issues with commit 87ec8e6c5a62 ("crt: Use .def
> > > files for fpreset and _fpreset on ARM targets.") which:
> > > - enabled underscored alias also for i386 and x64 msvcr120_app.dll builds
> > > - forgot to add underscored alias for arm32 msvcr110.dll builds
> > > - added duplicated code into individual msvcr*.def.in files, which was
> > > already de-duplicated
> > > - removed comment about DATA keywords (manually added needs to be
> > > revisited)
> >
> >
> > LGTM, thanks. The comment was intentionally removed, I think using the macro
> > is self-explanatory, but I don’t mind keeping it if it serves a purpose.
> >
>
> Those commends are good for checking or marking items which needs to be
> revisited. It is useful to know there is an extra DATA compared with
> gendef output.
Is anything else needed from me?
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
