On Sun, 2 Mar 2025, Jacek Caban wrote:
On 2.03.2025 21:29, Martin Storsjö wrote:
--- a/mingw-w64-crt/cfguard/mingw_cfguard_loadcfg.S
+++ b/mingw-w64-crt/crt/loadcfg.S
@@ -13,6 +13,12 @@ Many of the symbols referenced here are supplied by the
linker. This file has
been constructed with LLVM/LLD in mind.
*/
+#ifdef HAS_CFGUARD
+ .def @feat.00; .scl 3; .type 0; .endef
+ .globl @feat.00
+@feat.00 = 0x800
+#endif
+
I don't find this hunk mentioned/explained in the commit message? As far as
I can see, it emits things that we didn't emit before, so it's a bit
outside of the scope of this patch I think - feel free to split it out to a
separate patch with a separate explanation.
Other than that, this looks reasonable!
That was from my experimentation with implementing a better linker warning.
But since it's unrelated, I'll skip it for now. Thanks!
Yeah, after reading your second mail, I see the reasoning for it. It
probably makes sense to add it, but it definitely needs a separate
explanation.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
