Yeah looks great to me, thanks!

On Sat, 4 Jan 2025 at 14:22, LIU Hao <lh_mo...@126.com> wrote:
>
> 在 2025-01-04 20:24, Duncan Ogilvie 写道:
> >> Is there a reason why you changed the return type of 
> >> `RtlMultipleAllocateHeap` from `DWORD` to
> > `ULONG`? They are the same type and interchangeable.
> >
> > No reason, just found all the other definitions used ULONG (since
> > DWORD generally isn't available in the kernel/ntdll context).
> > Feel free to remove this part of the patch if it's undesirable :)
>
> winnt.h is not a kernel header but a user-mode header, and indeed contains 
> references to `DWORD`.
> The Microsoft header actually doesn't compile without including windows.h 
> first.
>
> I don't mind changing `DWORD` to `ULONG`; however there are occurrences in 
> arguments too.
>
> Does the attached patch look good to you?
>
>
> --
> Best regards,
> LIU Hao


_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to