On Fri, 20 Dec 2024, Jacek Caban wrote:
On 20.12.2024 16:09, Martin Storsjö wrote:
On Thu, 19 Dec 2024, Jacek Caban wrote:
From: Billy Laws <blaw...@gmail.com>
ARM64EC defines x86_64 identification macros, but its actual
intrinsics are aarch64-based. Since this
differs from what x86_64 code expects, MSVC additionally provides
softintrin.h (and softintrin.lib),
which act as wrappers to offer x86_64 variants of the intrinsics.
Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---
mingw-w64-headers/crt/intrin.h | 20 +++++++-------
.../include/psdk_inc/intrin-impl.h | 27 +++++++++----------
mingw-w64-headers/include/winnt.h | 12 ++++-----
3 files changed, 29 insertions(+), 30 deletions(-)
The changes feel quite noisy, but these headers are quite noisy
anyway, and I guess there's no good alterantives... So LGTM.
Pushed, thanks for the review.
FWIW, I was wondering if we need to account for both __arm64ec__ and
_ARM64EC_ here, but it's consistent with how we handle other platforms,
so I left it as is.
Yes, I technically think we could get rid of all the _ARM64EC_ style
definition checks and just go with the __gcc__ style - it would probably
make a lot of our headers and CRT code more readable and less noisy. But
until anybody does that, somewhat consistently, it's probably best to just
match the surrounding code style.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
