On Mon, 22 Jul 2024, Pali Rohár wrote:

On Monday 22 July 2024 16:02:42 Martin Storsjö wrote:
On Sat, 29 Jun 2024, Pali Rohár wrote:

C99 isblank symbol is natively available since msvcr120.dll, so include
mingw-w64 implementation of isblank to CRT import libraries only up to the
msvcr110 version.

This allows to use native isblank symbol for UCRT and msvcr120 builds.

Import libraries msvcr100 and msvcr110 currently do not have version
specific extra library, so define it and include it in MRI scripts.
---
mingw-w64-crt/Makefile.am             | 41 +++++++++++++++++++++------
mingw-w64-crt/lib-common/msvcr100.mri |  1 +
mingw-w64-crt/lib-common/msvcr110.mri |  1 +
3 files changed, 34 insertions(+), 9 deletions(-)

This change looks reasonable, but it broke building for arm32. Arm32 also
has got a copy of libmsvcr110.a, so we need to add rules for building
libmsvcr110_extra.a for that arch as well.

I did the necessary modifications for that, and pushed the change.

// Martin

Hello, in the git commit you have specified wrong flags for ARM builds:

libarm32_libmsvcr110_extra_a_CPPFLAGS=$(CPPFLAGS64) -D__LIBMSVCRT__ 
$(extra_include) $(sysincludes)

There should be CPPFLAGSARM32 instead of CPPFLAGS64.

Oops, thanks for catching it! I pushed a fix now.

// Martin

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to