On Sat, 8 Jun 2024, Pali Rohár wrote:
On Saturday 08 June 2024 08:25:49 Martin Storsjö wrote:
On Fri, 7 Jun 2024, Pali Rohár wrote:
On Tuesday 04 June 2024 15:39:46 Martin Storsjö wrote:
On Mon, 3 Jun 2024, Pali Rohár wrote:
Add once-guard to ensure that the file is processed only once.
Add arch-guard to ensure that DEF_<ARCH> is always defined to prevent an
issue that symbols defined via F32() macro completely disappeared and which
was fixed in previous change.
This change applied before the previous change cause compile errors.
---
mingw-w64-crt/def-include/func.def.in | 7 +++++++
1 file changed, 7 insertions(+)
Thanks, I pushed patches 1-2 from this set now right away, to get the fix
merged ASAP.
Ok, thanks. Maybe it is a candidate for v12.x branch?
Maybe? Which was the first commit that depend on these, where the output
started missing functions due to missing -DEF_<arch> - was that before or
after the v12.x branch?
I tracked it back to the commit b4638756158e947ce3ddde9e1b3b6f1f63d2ba03
(crt: Move find, stat and time aliases) in which are used F32() macros
by .def.in files outside of mingw-w64-crt/lib-common directory. So it
is before v12.x branch.
Ok, fair enough. Then it would be good to backport at least patch 1. Patch
2, which adds the errors if included without the right defines, perhaps
doesn't need to be backported, as that's mainly a development aid going
forward (although it would help verify that the fix works as intended) -
no strong opinion on that though.
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
