On Monday 03 June 2024 14:32:06 Martin Storsjö wrote:
> On Sun, 2 Jun 2024, Pali Rohár wrote:
>
> > msvcr80d.dll is debug version of the msvcr80.dll and provides additional
> > debugging functions.
> > ---
> > mingw-w64-crt/Makefile.am | 13 +-
> > mingw-w64-crt/lib-common/msvcr80d.mri | 6 +
> > mingw-w64-crt/lib32/msvcr80d.def.in | 1633 +++++++++++++++++++++++++
> > mingw-w64-crt/lib64/msvcr80d.def.in | 1575 ++++++++++++++++++++++++
> > 4 files changed, 3225 insertions(+), 2 deletions(-)
> > create mode 100644 mingw-w64-crt/lib-common/msvcr80d.mri
> > create mode 100644 mingw-w64-crt/lib32/msvcr80d.def.in
> > create mode 100644 mingw-w64-crt/lib64/msvcr80d.def.in
> >
> > diff --git a/mingw-w64-crt/Makefile.am b/mingw-w64-crt/Makefile.am
> > index 6b9f5f7b0f77..f8710f41e269 100644
> > --- a/mingw-w64-crt/Makefile.am
> > +++ b/mingw-w64-crt/Makefile.am
> > @@ -1114,7 +1114,8 @@ lib32_libmingwthrd_a_CPPFLAGS=$(CPPFLAGS32)
> > $(sysincludes)
> >
> > processed_defs += lib32/crtdll.def lib32/msvcrt10.def lib32/msvcrt20.def
> > lib32/msvcrt40.def lib32/msvcr40d.def \
> > lib32/msvcrt.def lib32/msvcrtd.def
> > lib32/msvcr70.def lib32/msvcr70d.def lib32/msvcr71.def lib32/msvcr71d.def \
> > - lib32/msvcr80.def lib32/msvcr90.def
> > lib32/msvcr90d.def lib32/msvcr100.def lib32/msvcr110.def lib32/msvcr120.def
> > lib32/msvcr120d.def \
> > + lib32/msvcr80.def lib32/msvcr80d.def
> > lib32/msvcr90.def lib32/msvcr90d.def lib32/msvcr100.def \
> > + lib32/msvcr110.def lib32/msvcr120.def
> > lib32/msvcr120d.def \
> > lib32/msvcr120_app.def lib32/msvcp120_app.def
> > lib32/ucrtbase.def \
> > lib32/api-ms-win-crt-math-l1-1-0.def
> > lib32/api-ms-win-crt-private-l1-1-0.def
> > lib32/api-ms-win-crt-runtime-l1-1-0.def \
> > lib32/api-ms-win-crt-filesystem-l1-1-0.def
> > lib32/api-ms-win-crt-time-l1-1-0.def \
> > @@ -1171,6 +1172,10 @@ lib32_DATA += lib32/libmsvcr80.a
> > lib32/libmsvcr80.a: lib-common/msvcr80.mri lib32/libmsvcr80_def.a
> > lib32/libmsvcrt_common.a lib32/libmsvcr80_extra.a
> > cd $(dir $@) && $(AR) -M < $(abspath $<)
> >
> > +lib32_DATA += lib32/libmsvcr80d.a
> > +lib32/libmsvcr80d.a: lib-common/msvcr80d.mri lib32/libmsvcr80d_def.a
> > lib32/libmsvcrt_common.a lib32/libmsvcr80_extra.a
> > + cd $(dir $@) && $(AR) -M < $(abspath $<)
> > +
> > lib32_DATA += lib32/libmsvcr90.a
> > lib32/libmsvcr90.a: lib-common/msvcr90.mri lib32/libmsvcr90_def.a
> > lib32/libmsvcrt_common.a lib32/libmsvcr90_extra.a
> > cd $(dir $@) && $(AR) -M < $(abspath $<)
> > @@ -1504,7 +1509,7 @@ lib64_LIBRARIES += lib64/libmingwthrd.a
> > lib64_libmingwthrd_a_SOURCES = $(src_libmingwthrd)
> > lib64_libmingwthrd_a_CPPFLAGS=$(CPPFLAGS64) $(sysincludes)
> >
> > -processed_defs += lib64/msvcrt.def lib64/msvcr80.def lib64/msvcr90.def
> > lib64/msvcr90d.def \
> > +processed_defs += lib64/msvcrt.def lib64/msvcr80.def lib64/msvcr80d.def
> > lib64/msvcr90.def lib64/msvcr90d.def \
> > lib64/msvcr100.def lib64/msvcr110.def
> > lib64/msvcr120.def lib64/msvcr120d.def \
> > lib64/msvcr120_app.def lib64/msvcp120_app.def
> > lib64/ucrtbase.def \
> > lib64/advapi32.def lib64/clbcatq.def
> > lib64/kernel32.def lib64/ole32.def \
> > @@ -1524,6 +1529,10 @@ lib64_DATA += lib64/libmsvcr80.a
> > lib64/libmsvcr80.a: lib-common/msvcr80.mri lib64/libmsvcr80_def.a
> > lib64/libmsvcrt_common.a lib64/libmsvcr80_extra.a
> > cd $(dir $@) && $(AR) -M < $(abspath $<)
> >
> > +lib64_DATA += lib32/libmsvcr80d.a
>
> Note the typo "lib32" here, this broke building for x86_64.
Ou. I have checked that that 32-bit compiled and linked test binary
works fine. I created extern manifest file "test.exe.manifest" with:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
<dependency>
<dependentAssembly>
<assemblyIdentity type="win32" name="Microsoft.VC80.DebugCRT"
version="8.0.50727.762" processorArchitecture="x86"
publicKeyToken="1fc8b3b9a1e18e3b"/>
</dependentAssembly>
</dependency>
</assembly>
And linked test.exe binary started correctly.
So I thought that 64-bit rechecking is not needed as whole mingw-w64
in 32-bit passed without any issue.
> I fixed this and pushed this patch, thanks!
Thanks for fixing it.
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
