在 2024-02-06 17:34, Martin Storsjö 写道:
This tool isn't evolving particularly much at the moment, so the additional value of knowing when a particular version was built doesn't give much extra value.Normally, a stripped build of gendef (on Linux) produces a binary with the exact same hash each time. Using __DATE__ breaks that reproducibility, if rebuilt on different days. It is possible to avoid the issue by setting SOURCE_DATE_EPOCH to a fixed value when building, but in this case, I think the printed date doesn't add much value, so we could simply remove it. Most other similar tools don't contain such printouts. Signed-off-by: Martin Storsjö <mar...@martin.st> --- mingw-w64-tools/gendef/src/gendef.c | 1 - 1 file changed, 1 deletion(-)
This patch looks good to me. Thanks.Ideally I would expect there to be a version string. A build date provides little useful information, so it may be removed for simplicity.
-- Best regards, LIU Hao
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
