By hardcoding the use of -Werror, we risk that the build can break
on any newer (or older) toolchain which can give warnings for
unexpected issues.
Fixing such issues is of course desired, but we shouldn't be breaking
the build universally, unless the user explicitly has asked for
this behaviour.
Signed-off-by: Martin Storsjö <mar...@martin.st>
---
FWIW, I didn't notice this with any actual issue in gendef/genpeimg,
I ran into it with an external toolchain issue that caused warnings,
which gendef then converted into a hard error.
---
mingw-w64-tools/gendef/Makefile.am | 2 +-
mingw-w64-tools/genpeimg/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mingw-w64-tools/gendef/Makefile.am
b/mingw-w64-tools/gendef/Makefile.am
index 20bf6dfb6..bcd85664c 100644
--- a/mingw-w64-tools/gendef/Makefile.am
+++ b/mingw-w64-tools/gendef/Makefile.am
@@ -4,7 +4,7 @@ AM_CPPFLAGS = @GENDEF_CPPFLAGS@
gendef_SOURCES = src/gendef.h src/compat_string.h src/gendef.c
src/gendef_def.c src/compat_string.c \
src/fsredir.c src/fsredir.h
-gendef_CFLAGS = $(AM_CFLAGS) -Werror -Wall -W
+gendef_CFLAGS = $(AM_CFLAGS) -Wall -W
EXTRA_DIST = $(srcdir)/ChangeLog*
DISTCHECK_CONFIGURE_FLAGS = --host=$(host) --with-mangle=@with_mangle@
diff --git a/mingw-w64-tools/genpeimg/Makefile.am
b/mingw-w64-tools/genpeimg/Makefile.am
index c7a5d5d89..3f5219b00 100644
--- a/mingw-w64-tools/genpeimg/Makefile.am
+++ b/mingw-w64-tools/genpeimg/Makefile.am
@@ -1,6 +1,6 @@
bin_PROGRAMS = genpeimg
genpeimg_SOURCES = src/img.h src/img.c src/img_pe.c src/genpeimg.c
genpeimg_CPPFLAGS = -Isrc
-genpeimg_CFLAGS = $(AM_CFLAGS) -O3 -g -Werror -Wall -Wextra
+genpeimg_CFLAGS = $(AM_CFLAGS) -O3 -g -Wall -Wextra
DISTCHECK_CONFIGURE_FLAGS = --host=$(host)
--
2.34.1
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
