> Am 15.01.2024 um 23:01 schrieb Martin Storsjö <mar...@martin.st>: > > On Fri, 12 Jan 2024, LIU Hao wrote: > >>> 在 2024/1/11 23:41, Antonin Décimo 写道: >>> The non-suffixed macro GetModuleHandle depends on whether the file is >>> being compiled in Unicode mode or not. Prefer using the char string >>> literal in this simple case. >>> Signed-off-by: Antonin Décimo <anto...@tarides.com> >>> --- >>> mingw-w64-libraries/winpthreads/src/misc.c | 2 +- >>> mingw-w64-libraries/winpthreads/src/thread.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> In my opinion the W variants should be preferred. Most A functions convert >> their arguments to wide strings then call their W variants anyway. > > I don't have a strong opinion on this matter. However, I have a very faint > memory, that such unicode functions were absent in the Win9x series - I'm > looping in Jonathan who posted the patches for making winpthreads work on > Win98 recently. So if it makes a difference for Win98, I'd prefer going with > the -A version, otherwise I don't have a strong opinion, and don't mind going > with the -W version. > > // Martin
Thanks for looping me in! I appreciate it a lot. Yes, the W version will indeed not work on Win98. The A version also has the advantage of needing half as much space for the string when it doesn’t contain Unicode anyway ;). I’m all for using the A suffix than none at all, to make it explicit. -- Jonathan _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
