On Fri, 5 Apr 2019, Jacek Caban wrote:
On 4/5/19 9:19 AM, Martin Storsjö wrote:
On Thu, 4 Apr 2019, Jacek Caban wrote:
It's already handled by importlibs.
Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---
mingw-w64-crt/Makefile.am | 2 +-
mingw-w64-crt/stdio/_ftime.c | 19 -------------------
2 files changed, 1 insertion(+), 20 deletions(-)
delete mode 100644 mingw-w64-crt/stdio/_ftime.c
This doesn't look correct. The patch talks about removing the function
_ftime, but the removed _ftime.c actually contains definitions of the
function ftime, without a leading underscore. There doesn't seem to be any
underscore-less import lib aliases for this function.
ftime (not underscored) is already forwarded to _ftime32/_ftime64 in
sys/timeb.h, which are handled by importlibs. Anyway, we may skip it for now.
Oh, ok - with the explanation that the header redirects it, not the import
lib, this could be fine. (But here we also have the same issue with extern
inline since this inline redirect uses __CRT_INLINE, which pretty much
presumes that there does exist an extern definition of the function
elsewhere.)
// Martin
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public