On Thursday, 29 March 2018 23:24:14, Liu Hao wrote:
在 2018/3/29 19:58, James Ross-Gowan 写道:
Will fix. Is there a line length limit for these header files? Without
the break, this line is over 120 chars.
No. The problem is that, if there are any warnings or errors related to
a function, GCC only prints the first line of the declaration in its
diagnostic messages. Hence if the declaration gets split into multiple
lines, our users will not see the entire list of parameters, without
taking a look into the header in question, of course.
Oh, right. That makes sense. I'll try to keep my function definitions on
a single line where I can.
The first two patches look good to me. Since the ARM and .def stuff are
beyond my ken, I am looking forward to others' opinion.
Thanks for the review. I just realised the ARM changes are broken. I'll
try to fix them as well, but I don't have a full ARM toolchain at the
moment.
Martin, who commented this thread a few days ago, will probably help.
Ah, good. I might need it. I think I can build the implibs with my
binutils, but I don't have an ARM toolchain yet, so I can't verify the
changes with test programs.
If it's better for me to just drop the ARM changes and wait for someone
else to make the implibs, I can do that too.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
