On Fri, 18 Aug 2017, Martell Malone wrote:
Attached updated patch.
I was itching to invert the .ctors markers so that I could do while (*p)
instead of while (*p != (func_ptr) -1)
but that would create another binutils breakage so I left it.
Let me know how you all want to proceed :)
Looks great to me! Just one tiny nit :P
-void
-__do_global_dtors (void)
+void __do_global_dtors (void)
{
static func_ptr *p = __DTOR_LIST__ + 1;
+ while (*p) {
+ (*(p))();
+ p++;
+ }
+}
- while (*p)
- {
- (*(p)) ();
- p++;
- }
I'd avoid the reindenting of this part, just to keep the diff even smaller
and simpler.
Other than that, no objections from me!
// Martin
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
