Hi. I've created a patch to MinGW-w64 that adds TaskDialog and TaskDialogIndirect to the comctl32 linker files on i386 and x86_64; these were missing, so linking programs that used these failed. (They are already in the headers, so compiling works fine.)

I don't know what the relevant lines should be on arm32. This was done by running MinGW-w64's gendef on Windows 7's DLLs.

Hopefully I've done everything correctly here. It seems to work, anyway.

After this, I'd like to add a few other things in future patches. One of these is CLSID_GlobalOptions (the class that implements IGlobalOptions, process-wide COM execution options). Is there some policy or formal documentation on how to edit MinGW-w64's header files to add these? (Microsoft has it in cguid.h. I'm not sure what DLL it's in, but gendef should tell us...)

Thanks,
Pietro Gagliardi (andlabs)
>From 90215ec8bdc5d1fdd48081aded6b57eb19cd1f83 Mon Sep 17 00:00:00 2001
From: Pietro Gagliardi <pietr...@mac.com>
Date: Sun, 7 Jun 2015 12:20:15 -0400
Subject: [PATCH] Added TaskDialog and TaskDialogIndirect to the comctl32.def
 for i386 and x86_64.

These were in the headers, but not the library files.

This does not cover arm32.

Values extracted by running gendef against actual Windows 7 DLLs.
---
 mingw-w64-crt/lib32/comctl32.def | 2 ++
 mingw-w64-crt/lib64/comctl32.def | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/mingw-w64-crt/lib32/comctl32.def b/mingw-w64-crt/lib32/comctl32.def
index d565941..5456a3b 100644
--- a/mingw-w64-crt/lib32/comctl32.def
+++ b/mingw-w64-crt/lib32/comctl32.def
@@ -114,3 +114,5 @@ Str_GetPtrA@12
 Str_GetPtrW@12
 Str_SetPtrA@8
 Str_SetPtrW@8
+TaskDialog@32
+TaskDialogIndirect@16
diff --git a/mingw-w64-crt/lib64/comctl32.def b/mingw-w64-crt/lib64/comctl32.def
index 91c557e..7199133 100644
--- a/mingw-w64-crt/lib64/comctl32.def
+++ b/mingw-w64-crt/lib64/comctl32.def
@@ -115,3 +115,5 @@ EnumMRUListW
 SetWindowSubclass
 RemoveWindowSubclass
 DefSubclassProc
+TaskDialog
+TaskDialogIndirect
-- 
2.1.4

------------------------------------------------------------------------------
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to