Well, that no other project uses already this header (and we can't be sure anyway here) is no reason for renaming it AFAICS. I see the point that this header might be now present under a different name, so why not adding this new header by including the old one then? By this we don't cause any hazzard, and well, it doesn't look so clear to me that old name is actually wrong.
Cheers, Kai 2015-03-07 17:59 GMT+01:00 Martell Malone <martellmal...@gmail.com>: > It seems no known project actually includes them this way yet > https://www.google.ie/search?q=Threadpoolapilegacyset.h > It's still nice to have the correct name though :) > > On Sat, Mar 7, 2015 at 4:57 PM, Martell Malone <martellmal...@gmail.com> > wrote: >> >> When I saw that these functions were implemented under winstorecompat. >> I checked to make sure we actually needed them for WINRT before I >> submitted the patch. >> >> I quickly noticed that MSDN has this comment written under HEADER for both >> of these functions. >> "Threadpoolapilegacyset.h on Windows 8 and Windows Server 2012" >> >> >> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682485%28v=vs.85%29.aspx >> >> https://msdn.microsoft.com/en-us/library/windows/desktop/ms682569%28v=vs.85%29.aspx >> >> >> On Fri, Mar 6, 2015 at 8:42 AM, Kai Tietz <ktiet...@googlemail.com> wrote: >>> >>> Hmm, where you got that the header-name is wrong? >>> >>> Kai >>> >>> 2015-03-05 1:33 GMT+01:00 Martell Malone <martellmal...@gmail.com>: >>> > The header name was incorrect :) >>> > I added WinStoreCompat support also >>> > >>> > Please Review >>> > >>> > >>> > ------------------------------------------------------------------------------ >>> > Dive into the World of Parallel Programming The Go Parallel Website, >>> > sponsored >>> > by Intel and developed in partnership with Slashdot Media, is your hub >>> > for >>> > all >>> > things parallel software development, from weekly thought leadership >>> > blogs >>> > to >>> > news, videos, case studies, tutorials and more. Take a look and join >>> > the >>> > conversation now. http://goparallel.sourceforge.net/ >>> > _______________________________________________ >>> > Mingw-w64-public mailing list >>> > Mingw-w64-public@lists.sourceforge.net >>> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >>> > >>> >>> >>> ------------------------------------------------------------------------------ >>> Dive into the World of Parallel Programming The Go Parallel Website, >>> sponsored >>> by Intel and developed in partnership with Slashdot Media, is your hub >>> for all >>> things parallel software development, from weekly thought leadership >>> blogs to >>> news, videos, case studies, tutorials and more. Take a look and join the >>> conversation now. http://goparallel.sourceforge.net/ >>> _______________________________________________ >>> Mingw-w64-public mailing list >>> Mingw-w64-public@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public >> >> ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
