Hi,
I replied already on IRC to vtorri for this patch. Issue I am
concerned is that the ..._r stuff isn't standard C stuff. Sure, as
vtorri told me, we provide gettimeofday too, which is a
Linux-C-runtime-function. I am not fond of providing this function by
default, but I remember strong issues by some ventures unable to
provide their own *working* version of it.
So what is the point about providing it for standard case? I am
concerned that we cause regression for projects assuming these
functions aren't present by default.
Kai
2014-10-07 12:08 GMT+02:00 Ozkan Sezer <seze...@gmail.com>:
> On 10/6/14, JonY <jo...@users.sourceforge.net> wrote:
>> On 10/4/2014 18:38, JonY wrote:
>>> This should be the same as the strtok_r case, the following will now be
>>> exposed:
>>> localtime_r
>>> gmtime_r
>>> ctime_r
>>> asctime_r
>>>
>>> Patch OK?
>>>
>>> diff --git a/mingw-w64-headers/crt/time.h b/mingw-w64-headers/crt/time.h
>>> index 5ce5849..1b228d8 100644
>>> --- a/mingw-w64-headers/crt/time.h
>>> +++ b/mingw-w64-headers/crt/time.h
>>> @@ -169,7 +169,6 @@ char *__cdecl ctime(const time_t *_Time)
>>> __MINGW_ATTRIB_DEPRECATED_SEC_WARN;
>>> struct tm *__cdecl gmtime(const time_t *_Time)
>>> __MINGW_ATTRIB_DEPRECATED_SEC_WARN;
>>> struct tm *__cdecl localtime(const time_t *_Time)
>>> __MINGW_ATTRIB_DEPRECATED_SEC_WARN;
>>>
>>> -#ifdef _POSIX
>>> #ifdef __GNUC__ /* FIXME: Other compilers that these macros work with?
>>> */
>>> #ifndef localtime_r
>>> #define localtime_r(_Time, _Tm) ({ struct tm *___tmp_tm =
>>> \
>>> @@ -215,7 +214,6 @@ struct tm *__cdecl localtime(const time_t *_Time)
>>> __MINGW_ATTRIB_DEPRECATED_SEC_
>>> #define ctime_r(_Time,_Str) (ctime ((_Time)) ? (strcpy((_Str),ctime
>>> ((_Time))),(_Str)) : 0)
>>> #endif
>>> #endif /* __GNUC__ */
>>> -#endif /* _POSIX */
>>>
>>> time_t __cdecl mktime(struct tm *_Tm);
>>> time_t __cdecl _mkgmtime(struct tm *_Tm);
>>>
>>
>> Ping, change OK?
>
> To me, the guard removal is good
>
>> Alternative, get a real implementation in mingwex?
>>
>
> ... which may (or may not) come later.
>
> ------------------------------------------------------------------------------
> Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
> Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
> Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
> Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
> http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
> _______________________________________________
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
