On 08/29/14 16:11, Ozkan Sezer wrote:
> On 8/29/14, Kai Tietz <ktiet...@googlemail.com> wrote:
>> /home/ktietz/out/0002-New-header-gpio.h.txt
>>
>> new Windows GUIDs ...
>>
>> /home/ktietz/out/0003-Update-shared-headers-for-DDK-for-winapi-family-check-.txt
>> New file hidclass.h and  updated other hid*.h headers for
>> winapi-family check and Win7/8 support
>>
>> /home/ktietz/out/0004-Add-monitor-configuration-API.txt
>> New monitor-configuration-API
>>
> Whitespace changes make the diffs really difficult to read:  Can you
> please (for future changesets) at least apply the whitespace changes
> beforehand and generate diffs for real changes?

When I review them, I apply them locally and use git diff -w. Maybe you
could send such patches in such form (I'm not sure how you generate
them, git format-patch -w should do the trick). It's not a good practice
to send patches in such form in general, but for patches doing a lot of
white space changes, that makes things a lot easier to review.

Cheers,
Jacek

------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to