On 08/19/13 10:52, Rafaël Carré wrote:
> Le 19/08/2013 09:02, Dongsheng Song a écrit :
>> cauchy@CRM-SYSLOG:~/obj/i686-w64-mingw32-gcc48/mingw-w64-crt$ make
>> make  all-am
>> make[1]: Entering directory
>> `/home/cauchy/obj/i686-w64-mingw32-gcc48/mingw-w64-crt'
>> i686-w64-mingw32-gcc -DHAVE_CONFIG_H -I.
>> -I/home/cauchy/vcs/svn/mingw-w64/trunk/mingw-w64-crt  -m32
>> -I/home/cauchy/cross/i686-windows-gcc48/i686-w64-mingw32/include
>> -pipe -std=gnu99 -Wall -Wextra -Wformat -Wstrict-aliasing -Wshadow
>> -Wpacked -Winline -Wimplicit-function-declaration -Wmissing-noreturn
>> -Wmissing-prototypes -g -O2 -MT libsrc/lib32_libuuid_a-uuid.o -MD -MP
>> -MF libsrc/.deps/lib32_libuuid_a-uuid.Tpo -c -o
>> libsrc/lib32_libuuid_a-uuid.o `test -f 'libsrc/uuid.c' || echo
>> '/home/cauchy/vcs/svn/mingw-w64/trunk/mingw-w64-crt/'`libsrc/uuid.c
> This should be fixed by:
>
> diff --git a/mingw-w64-crt/libsrc/uuid.c b/mingw-w64-crt/libsrc/uuid.c
> index fa9b1e0..ed25459 100644
> --- a/mingw-w64-crt/libsrc/uuid.c
> +++ b/mingw-w64-crt/libsrc/uuid.c
> @@ -16,15 +16,6 @@
>  #define INITGUID
>  #include <basetyps.h>
>
> -#include <textstor.h>
> -#include <shobjidl.h>
> -#include <propkey.h>
> -#include <isguids.h>
> -#include <shlguid.h>
> -#include <urlhist.h>
> -#include <oleacc.h>
> -#include <uiautomation.h>
> -
>  
> DEFINE_GUID(ARRAYID_PathProperties,0x7ecbba04,0x2d97,0x11cf,0xa2,0x29,0,0xaa,0,0x3d,0x73,0x52);
>  
> DEFINE_GUID(CATID_Control,0x40fc6ed4,0x2438,0x11cf,0xa3,0xdb,0x8,0,0x36,0xf1,0x25,0x2);
>  
> DEFINE_GUID(CATID_DocObject,0x40fc6ed8,0x2438,0x11cf,0xa3,0xdb,0x8,0,0x36,0xf1,0x25,0x2);
>

No, duplicates should be removed from uuid.c, not includes. Your patch
would remove a lot of important GUIDs from libuuid.a.

Jacek

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to