Hi Jacek,
Sorry for the long response time.
Please find attached a new version of the patch that adds the warning
you mentioned.
I also named it as .a txt file and removed all auto generated files.
Best regards,
Ray.
On Mon, Jan 14, 2013 at 12:40 PM, Jacek Caban <[email protected]> wrote:
> Hi Ray,
>
> .idl.h: crt/_mingw.h
> - $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include
> -I$(srcdir)/direct-x/include -Icrt -I$(srcdir)/crt -h -o $(srcdir)/$@ $<
> + $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include
> -I$(srcdir)/direct-x/include -Icrt -I$(srcdir)/crt -h -o $@ $<
>
>
> The current code is indeed a hack, but it's intentional. Compiling with
> --with-widl is a maintainer-like mode and is supposed to change files in
> source directories.
>
> That said, --with-widl works best if ran in config where
> srcdir=builddir, because widl-generated comments look better then. We
> could change the way it works like you propose (so that if someone
> really wants widl-maintainer more, he is expected to build from srcdir),
> but for that I think we'd need a warning in configure when someone uses
> --with-widl and srcdir!=builddir.
>
> Thanks,
> Jacek
>
> ------------------------------------------------------------------------------
> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
> MVPs and experts. SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122412
> _______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
Index: mingw-w64-headers/Makefile.am
===================================================================
--- mingw-w64-headers/Makefile.am (revision 5578)
+++ mingw-w64-headers/Makefile.am (working copy)
@@ -118,10 +118,14 @@
BUILT_SOURCES = $(IDL_SRCS:.idl=.h)
.idl.h: crt/_mingw.h
- $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include -I$(srcdir)/direct-x/include
-Icrt -I$(srcdir)/crt -h -o $(srcdir)/$@ $<
+ $(WIDL) -DBOOL=WINBOOL -I$(srcdir)/include -I$(srcdir)/direct-x/include
-Icrt -I$(srcdir)/crt -h -o $@ $<
+if SRCDIR_NEQ_BUILDDIR
+$(warning "srcdir != builddir, debugging comments in idl files will be
sub-optimal")
endif
+endif
+
_mingw_directx.h: $(srcdir)/crt/sdks/_mingw_directx.h.in
$(SED) s/MINGW_HAS_DX$$/@MINGW_HAS_DX@/ $< > $@
Index: mingw-w64-headers/configure.ac
===================================================================
--- mingw-w64-headers/configure.ac (revision 5578)
+++ mingw-w64-headers/configure.ac (working copy)
@@ -10,6 +10,9 @@
AM_INIT_AUTOMAKE([foreign])
AM_MAINTAINER_MODE
+# Check so we can warn about this.
+AM_CONDITIONAL([SRCDIR_NEQ_BUILDDIR],[test ! "$srcdir" = "$builddir"])
+
AC_CANONICAL_HOST
# Checks for programs.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
