Hi Bruce
I'm sorry to misunderstood your emails.
Now I will resend the v2 patch like following:
1.
To use PACKAGECONFIG instead of EXTRA_OECONF
PACKAGECONFIG[systemd] = "--with-systemd
--with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd,"
1.
Summarize what has changed in a v2 below the --- like
......
Signed-off-by: Liu Yiding <[email protected]>
---
Changes in v2:
- Improved commit message to explain the sysvinit case
- Use PACKAGECONFIG instead of EXTRA_OECONF
Is that OK?
Liu
________________________________
发件人: Bruce Ashfield <[email protected]>
发送时间: 2026年2月12日 12:57
收件人: Liu, Yiding/刘 乙丁 <[email protected]>
抄送: [email protected]
<[email protected]>
主题: Re: [meta-virtualization][PATCH v2] irqbalance: Fix QA error when sysvinit
is used
On Wed, Feb 11, 2026 at 10:09 PM Yiding Liu (Fujitsu) via
lists.yoctoproject.org<http://lists.yoctoproject.org>
<[email protected]<mailto:[email protected]>>
wrote:
irqbalance: correct to install /etc/default for sysvinit
1. This commit uses option --with-pkgconfdir to correct to install /etc/default
when sysvinit is used.
Without this fix, there will show do_package QA Issue
ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance:
Files/directories were installed but not shipped in any package:
/usr/etc
/usr/etc/default
/usr/etc/default/irqbalance.env
Previous PACKAGECONFIG[systemd] only works when systemd is used. When using
sysvinit, --with-pkgconfdir=${sysconfdir} can't work, so making this patch to
fix it.
2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd]
You need to address my review comments directly.
Also, summarize what has changed in a v2 below the --- in the patch itself.
Cheers,
Bruce
Signed-off-by: Liu Yiding
<[email protected]<mailto:[email protected]>>
---
recipes-extended/irqbalance/irqbalance.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/recipes-extended/irqbalance/irqbalance.inc
b/recipes-extended/irqbalance/irqbalance.inc
index 35b6388e..b7b34a0b 100644
--- a/recipes-extended/irqbalance/irqbalance.inc
+++ b/recipes-extended/irqbalance/irqbalance.inc
@@ -14,7 +14,6 @@ LIC_FILES_CHKSUM =
"file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
"
DEPENDS = "glib-2.0"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '',
d)}"
INITSCRIPT_NAME = "irqbalanced"
INITSCRIPT_PARAMS = "defaults"
@@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance"
SYSTEMD_SERVICE:irqbalance = "irqbalance.service"
EXTRA_OECONF = "--program-transform-name= \
+ --with-pkgconfdir=${sysconfdir} \
"
# let the recipes or appends define options
@@ -34,7 +34,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES',
'systemd', 'systemd',
#
PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl,"
PACKAGECONFIG[libcap-ng] = "--with-libcap-ng,--without-libcap-ng,libcap-ng,"
-PACKAGECONFIG[systemd] = "--with-systemd --with-pkgconfdir=${sysconfdir},,,"
+PACKAGECONFIG[systemd] = "--with-systemd,,systemd"
do_install () {
oe_runmake 'DESTDIR=${D}' install
--
2.43.0
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at
its end
- "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9584):
https://lists.yoctoproject.org/g/meta-virtualization/message/9584
Mute This Topic: https://lists.yoctoproject.org/mt/117787068/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
