On Wed, Feb 11, 2026 at 12:35 PM Bruce Ashfield via lists.yoctoproject.org <[email protected]> wrote:
> We'll agree to disagree :) > I should add that I didn't dig into if the false case of the systemd packageconfig runs when it isn't set. If it doesn't then yes, obviously we need it somewhere else. I'd very much prefer a sysvinit package config if someone is enabling this, and not using systemd. So the false case doesn't really matter from that point of view. Bruce > > Bruce > > On Wed, Feb 11, 2026 at 10:58 AM Peter Kjellerstedt < > [email protected]> wrote: > >> Umm, I would argue that the initially proposed patch is correct (except >> for a better explanation in the commit message). If the >> --with-pkgconfdir=${sysconfdir}" shall be set both with and without >> systemd enabled, then adding it to EXTRA_OECONF is the correct thing to >> do as it shall always be set regardless of any PACKAGECONFIG. >> >> >> >> //Peter >> >> >> >> *From:* [email protected] < >> [email protected]> *On Behalf Of *Bruce >> Ashfield via lists.yoctoproject.org >> *Sent:* den 11 februari 2026 15:12 >> *To:* Yiding Liu (Fujitsu) <[email protected]> >> *Cc:* [email protected] >> *Subject:* Re: [meta-virtualization][PATCH] irqbalance: Fix >> PACKAGECONFIG[systemd] parameter >> >> >> >> >> >> >> >> On Wed, Feb 11, 2026 at 2:09 AM Yiding Liu (Fujitsu) < >> [email protected]> wrote: >> >> Hi Bruce >> >> >> >> >Which is what that first field is trying to do. So is there an >> >> issue in the configure that isn't passing it through ? Is it >> >> the combination of that plus our EXTRA_OECONF ? >> >> >> >> There is no issue with "PACKAGECONFIG[systemd] = "--with-systemd >> --with-pkgconfdir=${sysconfdir},,," >> >> >> >> But it only works when using systemd, so in that condition, there is no >> do_package QA Issue about install path. >> >> >> >> When using sysvinit, PACKAGECONFIG[systemd] can't work, so I need to make >> this patch to fix it. >> >> >> >> I want to make "—with-pkgconfdir=${sysconfdir}" works for both systemd >> and sysvinit. >> >> >> >> >> >> This is the information that needs to be in the commit message. The goal >> of fixing the >> >> QA error when sysvinit is used. >> >> >> But since the packageconfig has a field for adding the options when the >> packagconfig is >> >> disabled, then we should be able to collapse everything to something like >> this: >> >> >> >> # when systemd is not enabled in PACKAGECONFiG, we just pass >> --with-pkgconfdir for sysvinit >> >> PACKAGECONFIG[systemd] = "--with-systemd >> --with-pkgconfdir=${sysconfdir},--with-pkgconfdir=${sysconfdir},systemd," >> >> >> >> unless you have both sysvinit and systemd enabled at once. >> >> >> >> Alternatively, we introduce a sysvinit PACKAGE config and pass the >> options there. >> >> >> The packageconfig is self documenting as to why we want the option >> passed, versus >> >> moving it to the EXTRA_OECONF. >> >> Bruce >> >> >> >> >> >> >> >> >> >> >> >> Liu >> >> >> ------------------------------ >> >> *发件人**:* Bruce Ashfield <[email protected]> >> *发送时间**:* 2026年2月5日 09:50 >> *收件人**:* Liu, Yiding/刘 乙丁 <[email protected]> >> *抄送**:* [email protected] < >> [email protected]> >> *主**题**:* Re: [meta-virtualization][PATCH] irqbalance: Fix >> PACKAGECONFIG[systemd] parameter >> >> >> >> You don't often get email from [email protected]. Learn why this >> is important <https://aka.ms/LearnAboutSenderIdentification> >> >> >> >> >> >> On Sun, Jan 25, 2026 at 10:44 PM Yiding Liu (Fujitsu) via >> lists.yoctoproject.org <[email protected]> >> wrote: >> >> irqbalance: correct to install /etc/default for sysvinit >> >> 1. This commit uses option --with-pkgconfdir to correct to install >> /etc/default >> Without this fix, there will show do_package QA Issue >> ERROR: irqbalance-1.9.4+git-r0 do_package: QA Issue: irqbalance: >> Files/directories were installed but not shipped in any package: >> /usr/etc >> /usr/etc/default >> /usr/etc/default/irqbalance.env >> >> 2. Merge DEPENDS for systemd into PACKAGECONFIG[systemd] >> >> Signed-off-by: Liu Yiding <[email protected]> >> --- >> recipes-extended/irqbalance/irqbalance.inc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/recipes-extended/irqbalance/irqbalance.inc >> b/recipes-extended/irqbalance/irqbalance.inc >> index 35b6388e..b7b34a0b 100644 >> --- a/recipes-extended/irqbalance/irqbalance.inc >> +++ b/recipes-extended/irqbalance/irqbalance.inc >> @@ -14,7 +14,6 @@ LIC_FILES_CHKSUM = >> "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ >> " >> >> DEPENDS = "glib-2.0" >> -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', >> 'systemd', '', d)}" >> >> INITSCRIPT_NAME = "irqbalanced" >> INITSCRIPT_PARAMS = "defaults" >> @@ -25,6 +24,7 @@ SYSTEMD_PACKAGES = "irqbalance" >> SYSTEMD_SERVICE:irqbalance = "irqbalance.service" >> >> EXTRA_OECONF = "--program-transform-name= \ >> + --with-pkgconfdir=${sysconfdir} \ >> " >> >> # let the recipes or appends define options >> @@ -34,7 +34,7 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', >> 'systemd', 'systemd', >> # >> PACKAGECONFIG[numa] = >> <$%[email protected]('DISTRO_FEATURES',%20'systemd',%20'systemd',%0b%C2%A0#+%C2%A0PACKAGECONFIG[numa]+=> >> "--enable-numa,--disable-numa,numactl," >> PACKAGECONFIG[libcap-ng] = >> "--with-libcap-ng,--without-libcap-ng,libcap-ng," >> -PACKAGECONFIG[systemd] = "--with-systemd >> --with-pkgconfdir=${sysconfdir},,," >> >> >> >> We should explain this change more in the commit message. >> >> irqbalance uses autotools and that's one of the classes that >> >> is supposed to pick up PACKAGECONFIG_CONFARGS. >> >> >> >> Which is what that first field is trying to do. So is there an >> >> issue in the configure that isn't passing it through ? Is it >> >> the combination of that plus our EXTRA_OECONF ? >> >> >> >> Bruce >> >> >> >> +PACKAGECONFIG[systemd] = "--with-systemd,,systemd" >> >> do_install () { >> oe_runmake 'DESTDIR=${D}' install >> -- >> 2.43.0 >> >> >> >> >> >> >> >> -- >> >> - Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end >> - "Use the force Harry" - Gandalf, Star Trek II >> >> >> >> >> -- >> >> - Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end >> - "Use the force Harry" - Gandalf, Star Trek II >> > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await thee > at its end > - "Use the force Harry" - Gandalf, Star Trek II > > > > > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9580): https://lists.yoctoproject.org/g/meta-virtualization/message/9580 Mute This Topic: https://lists.yoctoproject.org/mt/117756607/21656 Group Owner: [email protected] Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
