On Tue, Feb 2, 2010 at 9:17 PM, Chia-I Wu <[email protected]> wrote: > On Tue, Feb 2, 2010 at 11:43 AM, Mike Stroyan <[email protected]> wrote: >> On Mon, Feb 1, 2010 at 7:34 PM, Chia-I Wu <[email protected]> wrote: >>> On Tue, Feb 2, 2010 at 2:49 AM, Mike Stroyan <[email protected]> wrote: >>>> Here is a version of the patch that uses EGL_DRIVERS_PATH and checks >>>> for setuid/setgid >>>> before using EGL_DRIVER or EGL_DRIVERS_PATH. >>> The patch seems to be missing :) >> Here is the missing patch file. > The patch looks good. But when I tried to make EGL_DRIVER and the default > driver also honor EGL_DRIVERS_PATH, it turned out that I need to overhaul both > the existing code and your patch. > > I've attached my version in this mail. It is based on your work. Please have > a look. If you think it looks fine, I will go ahead and commit. > > -olv >
This version looks good enough to check in. I am not fond of the static 'search_path' and 'buffer' variables in _eglGetSearchPath. It will be one more place to revisit when you come back to work on thread safety. But I understand that it will reduce the time spent formatting the search path. -- Mike Stroyan - Software Architect LunarG, Inc. - The Graphics Experts Cell: (970) 219-7905 Email: [email protected] Website: http://www.lunarg.com ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
