On Tue, Jan 5, 2010 at 11:51 PM, Brian Paul <[email protected]> wrote:
> Roel Kluin wrote:
>>
>> These can never be true.
>>
>> Signed-off-by: Roel Kluin <[email protected]>
>> ---
>> src/gallium/drivers/i965/brw_wm_emit.c | 2 +-
>> src/mesa/drivers/dri/i915/intel_tris.c | 2 +-
>> src/mesa/drivers/dri/i965/brw_wm_emit.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>> @@ -691,7 +691,7 @@ static void emit_xpd( struct brw_compile *p,
>> {
>> GLuint i;
>> - assert(!(mask & BRW_WRITEMASK_W) == BRW_WRITEMASK_X);
>> + assert((mask & BRW_WRITEMASK_W) != BRW_WRITEMASK_X);
>> for (i = 0 ; i < 3; i++) {
>> if (mask & (1<<i)) {
>> @@ -692,7 +692,7 @@ void emit_xpd(struct brw_compile *p,
>> {
>> GLuint i;
>> - assert(!(mask & WRITEMASK_W) == WRITEMASK_X);
>> + assert((mask & WRITEMASK_W) != WRITEMASK_X);
>> for (i = 0 ; i < 3; i++) {
>> if (mask & (1<<i)) {
>> .
>>
>
> I believe the first and third assertions should read:
>
> assert(!(mask & BRW_WRITEMASK_W) == BRW_WRITEMASK_W);
>
> I'll fix those.
I think you mean
assert((mask & BRW_WRITEMASK_W) != BRW_WRITEMASK_W);
You probably know this: `!' has a higher precedence than `==' so
the `!(mask & BRW_WRITEMASK_W)' part evaluates either to 0 or 1
and can never be BRW_WRITEMASK_W (defined 0x8).
> -Brian
thanks,
Roel
------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
