http://bugs.freedesktop.org/show_bug.cgi?id=25016
--- Comment #7 from Maciej Cencora <[email protected]> 2009-12-04 08:57:55 PST --- (In reply to comment #6) > I'm taking a quick look at the diffs between > 0ea575d721821262a862ceef010db9b1a8b4a6d9 and > 1f196b786d6bd0c6a5dbdc638574ff716cc3d4de > > One thing that looks suspicious is the VALID_FORMAT() macro used in the > radeon/r200/r300/etc drivers. I have no idea what it's supposed to do, but it > depends on the order/value of the MESA_FORMAT_x tokens. That's pretty > fragile. > The order of the formats may have changed a bit on the texformat-rework > branch. > > Also, the tx_table[] array is indexed with a MESA_FORMAT_x value so it depends > on the MESA_FORMAT_x enums never changing (again, fragile). This should > probably be converted into a switch/case in a utility function. > > Maybe one of the radeon developers can look into this. > I'll look into it. -- Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
