On Thu, Nov 19, 2009 at 8:28 AM, Brian Paul <[email protected]> wrote:
> tom fogal wrote:
>> Brian Paul <[email protected]> writes:
>>> Please test and report any problems ASAP. If there aren't any issues
>>> we'd like to release 7.6.1 on Friday or Saturday.
>>
>> We've had the attached AIX patch locally for a while now. Sorry I
>> didn't send it earlier. I wrote a small C program to compare it to
>> Linux's bswap_32 and it seems to work, but I'll note it's untested in
>> Mesa; for build-dep reasons, we need an Xlib-based Mesa, but we never
>> call that code at runtime. Further, I inserted #error blah in the
>> define used here, and the Mesa build succeeded... so this is obviously
>> never even called in the configurations I am concerned with.
>>
>> Secondly, the AIX build is failing in progs/Makefile. The quoting
>> introduced in 115edf24a9128b79dfa5f30482c990e2cb898357 and removed in
>> 31f7e8efb25a77e3bdfb6e9850cf31e339060976 was important. Otherwise,
>> SUBDIRS will end up being " " or maybe " " and test -n will
>> (annoyingly) fail, causing the `for'-over-nothing to execute.
>>
>> The (second) attached patch fixes it, I believe in both cases. At
>> least, with Mesa-7.6.1-rc1 I get the error mentioned in 31f7.. from
>> `make linux', and now I don't (and it still works on AIX).
>
> OK, I've applied both patches.
>
> The $(strip ...) syntax is GNU-make specific, I think. If it causes
> trouble for anyone we'll revisit it.
Sorry, I meant to comment on this earlier, but I was really busy. I
think the reason that the make variable ends up with a space in it
instead of being empty is the automatic demos checking in configure. I
think it would be better to fix it there so that you either get a list
of directories or an empty variable. I don't have time to test, but I
think this would fix it:
diff --git a/configure.ac b/configure.ac
index cc588d5..5ffe93c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -486,7 +486,7 @@ yes)
test -d "$srcdir/progs/$demo" || \
AC_MSG_ERROR([Program directory '$demo' doesn't exist])
done
- PROGRAM_DIRS="$demos"
+ PROGRAM_DIRS=`echo $demos | $SED 's/^ *//'`
;;
esac
Tom, what arguments do you pass to configure?
--
Dan
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
