-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
In _mesa_GetTexLevelParameteriv there are checks in all the
GL_TEXTURE_*_BITS queries that the base format has the specified component:
case GL_TEXTURE_RED_SIZE:
case GL_TEXTURE_GREEN_SIZE:
case GL_TEXTURE_BLUE_SIZE:
if (img->_BaseFormat == GL_RGB || img->_BaseFormat == GL_RGBA)
*params = _mesa_get_format_bits(texFormat, pname);
else
*params = 0;
break;
case GL_TEXTURE_ALPHA_SIZE:
if (img->_BaseFormat == GL_ALPHA ||
img->_BaseFormat == GL_LUMINANCE_ALPHA ||
img->_BaseFormat == GL_RGBA)
*params = _mesa_get_format_bits(texFormat, pname);
else
*params = 0;
break;
Since the values are stored in a big table in formats.c, are these
checks really necessary? If the base format is GL_INTENSITY, the
redBits entry in the table is already 0.
Am I missing something?
I'm reviving the texture_rg branch (actually a new branch), and I'd like
to clean this up, if possible, before adding more if-checks for GL_RED
and GL_RG textures when querying GL_TEXTURE_RED_SIZE and
GL_TEXTURE_BLUE_SIZE.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAksEciMACgkQX1gOwKyEAw90KACfbzFOIACBA2yrcYjWv0sT1MVu
SQgAniYWM5mFg7e4UIbOGYNSZqFSbmgm
=Ncx3
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
