Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Brian Paul wrote: >> On Mon, Nov 2, 2009 at 3:20 PM, Ian Romanick <[email protected]> wrote: >>> This patch series enables glProgramStringARB to handle NV vertex and >>> fragment programs when the appropriate extensions are supported. It >>> also enables glLoadProgramNV to handle ARB vertex and fragment >>> programs. This behavior is described in the "Interactions with" >>> sections of ARB_vertex_program and NV_fragment_program. >> Did someone's app hit this functionality? > > I recently modified piglit's vpfp-generic test to use the ARB functions > for both ARB and NV vertex programs. It worked fine on Nvidia binary > drivers, but it failed on Mesa. > >>> These are the least intrusive patches for the 7.6 release branch. >>> Ideally the ARB parser would be extended to handle the NV programs, >>> and a lot of the existing NV handling code would be refactored. This >>> seems too intrusive for the stable branch, especially since we don't >>> have a good parser test suite for the NV programs. >>> >>> One quirk that bothers me about the existing code: glLoadProgramNV >>> doesn't call Driver.ProgramStringNotify. Is this intentional? >> Probably an oversight. Driver.ProgramStringNotify() is used to tell >> the driver that a vertex/fragment program has been changed. > > Do you think I should modify LoadProgramNV to be like ProgramStringARB?
If you mean call ctx->Driver.ProgramStringNotify(), yes. > I'll probably do some additional refactoring in the master after these > patches hit the stable branch. OK. -Brian ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
