Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Brian Paul wrote: > >>Ian Romanick wrote: >> >>>Brian Paul wrote: >>> >>> >>>>In order to do 1, each driver must be updated. Basically, before a >>>>GLframebuffer is bound for the first time, it must be initialized. >>>>Specifically, the GLframebuffer's Width and Height fields need to be >>>>set correctly and _mesa_resize_framebuffer() should be called in order >>>>to make sure the software buffers (accum, stencil, etc) are allocated >>>>to the proper size). >>>> >>>>In the intel drivers, it looks like the preceeding call to >>>>intelWindowMoved() will do this. >>>> >>>>I've added #ifdef/#else/#endif in _mesa_make_current() to show what >>>>code should be removed, and to check that the caller does what's expected. >>>> >>>>I'm looking for a maintainer of each DRI driver to change the #if 1 to >>>>#if 0 and update the driver code to do the needed initializations. >>>>I'll try to do this for the i915 driver once I get my DRI environment >>>>up to date. >>> >>>I can handle this for radeon and mga. It looks like this means just >>>adding a the call to _mesa_resize_framebuffer to the driver's >>>MakeCurrent routine. >> >>That's basically it. But you don't want to do it unconditionally, >>just the first time the buffer is bound. Also, set the buffer's >>Initialized flag = GL_TRUE, to avoid the soon-to-be-obsolete code in >>_mesa_make_current(). >> >>The Initalized flag will eventually be removed. > > > Here's my patch for the Radeon driver.
Looks good. > There's some additional code in > there to enable GLX_SGI_make_current_read. Is it necessary to do the > same initialization on the read-drawable as on the draw-drawable? Yes. If the app (such as progs/xdemos/wincopy) uses glCopyPixels to copy a region from one window to the next, we need to do some sort of clip testing both for the destination and source. We don't want to read pixels that are out of bounds. If you're testing progs/xdemos/wincopy, be sure to resize both windows a bit to exercise things. -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
