Ian Romanick wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I've been going through and doing some cleaning in the code generation > Python scripts. Some of the scripts, glX_proto_send.py in particular, > have a bunch of crap around to keep the indentation of the generated > code consistent. > > The Python code would read *much* better if I could just eliminate all > of that and run the generated code through indent. With some > experimentation, I found that "indent -i4 -nut -br -brs -npcs -ce" > matches the existing code fairly closely. The biggest difference seems > to be that some sequences in the existing code get packed onto one line, > but indent separates them. The result is 12,872 lines of diffs and > ~1,500 new lines of code in src/glx/x11/indent.c. > > Even though this is "just" whitespace changes, I'd intend this to be > post-6.5.1. > > Opinions?
The indentation of auto-generated code isn't a big deal to me. One can always run indent manually if needed for debugging/etc. Either way is OK w/ me. -Brian ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Mesa3d-dev mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
