On 5/29/06, Tilman Sauerbeck <[EMAIL PROTECTED]> wrote:
Brian Paul [2006-05-29 08:36]:
> Jesse Allen wrote:
> >A recent change to arbprogparse.c on Apr 28 is causing references to vertex
> >attrib zero to crash. I'm not entirely sure on how it is supposed to be
> >handled now, but my guess from trial and error is found below. Someone please
> >take a look.
> >Changes:
> >Be more strict on the vertex attrib array bounds and use an absolute zero for
> >vertex attrib zero.
>
> Thanks for the patch. Looks good - I'll check it in.
I think the first chunk of changes introduced by this patch is
unnecessary.
parse_generic_attrib_num() already checks whether the vertex attrib
number is >= MAX_VERTEX_PROGRAM_ATTRIBS, in which case it returns 1. So
the second check (the one introduced by the patch) is never executed.
Maybe I'm missing something though.
Regards,
Tilman
Yes, your right, I missed that. No need to do it again.
-------------------------------------------------------
All the advantages of Linux Managed Hosting--Without the Cost and Risk!
Fully trained technicians. The highest number of Red Hat certifications in
the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnk&kid7521&bid$8729&dat1642
_______________________________________________
Mesa3d-dev mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
